Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format HTTP headers in span attributes #41

Merged
merged 3 commits into from
Apr 23, 2024

Conversation

cyve
Copy link
Collaborator

@cyve cyve commented Apr 7, 2023

Before (the header names are missing, only the values are displayed) :
Capture d’écran 2023-04-07 à 15 46 07

After :
Capture d’écran 2023-04-07 à 15 35 13

@cyve cyve requested a review from cdaguerre April 7, 2023 13:51
@cdaguerre cdaguerre force-pushed the master branch 2 times, most recently from 633595f to cee36ca Compare March 12, 2024 10:36
Copy link
Member

@cdaguerre cdaguerre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, could you fix tests?

@GCalmels GCalmels force-pushed the fix-http-headers-attributes branch from 03acbd7 to 84eadde Compare April 23, 2024 15:06
@cdaguerre cdaguerre merged commit f2b25a0 into master Apr 23, 2024
8 checks passed
@cdaguerre cdaguerre deleted the fix-http-headers-attributes branch April 23, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants